From: Chris Wilson Date: Tue, 22 Aug 2017 11:05:16 +0000 (+0100) Subject: drm/i915: Assert that the handle->vma lut is empty on object close X-Git-Tag: v4.19~298^2~46^2~1753 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=67b48040255b77ea7d11e68e07c83e502308c65d;p=platform%2Fkernel%2Flinux-rpi.git drm/i915: Assert that the handle->vma lut is empty on object close Make sure that we are not leaking an entry in the ctx->handles_lut by asserting that the object was removed prior to being freed. This should be enforced by all such handles being removed by i915_gem_close_object. Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20170822110517.22277-2-chris@chris-wilson.co.uk Reviewed-by: Michał Winiarski --- diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 3ed9fb0..5dc396c 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -4416,6 +4416,7 @@ static void __i915_gem_free_objects(struct drm_i915_private *i915, llist_for_each_entry_safe(obj, on, freed, freed) { GEM_BUG_ON(obj->bind_count); GEM_BUG_ON(atomic_read(&obj->frontbuffer_bits)); + GEM_BUG_ON(!list_empty(&obj->lut_list)); if (obj->ops->release) obj->ops->release(obj);