From: Colin Ian King Date: Sun, 16 Oct 2016 22:54:03 +0000 (+0100) Subject: cxgb4: fix memory leak of qe on error exit path X-Git-Tag: v5.15~12545^2~92 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=67b11e2ea704f99953f18585609df17b6e189e53;p=platform%2Fkernel%2Flinux-starfive.git cxgb4: fix memory leak of qe on error exit path A memory leak of qe occurs when t4_sched_queue_unbind fails, so fix this by free'ing qe on the error exit path. Signed-off-by: Colin Ian King Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c index 539de76..cbd68a8 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/sched.c +++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c @@ -210,8 +210,10 @@ static int t4_sched_queue_bind(struct port_info *pi, struct ch_sched_queue *p) /* Unbind queue from any existing class */ err = t4_sched_queue_unbind(pi, p); - if (err) + if (err) { + t4_free_mem(qe); goto out; + } /* Bind queue to specified class */ memset(qe, 0, sizeof(*qe));