From: Stefan Kost <ensonic@users.sf.net>
Date: Thu, 26 Feb 2009 09:02:06 +0000 (+0200)
Subject: baseparse: remove checks for buffer==NULL
X-Git-Tag: RELEASE-0.10.29~456
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=675dc650ca311c26929b4eeba133ad2bed8049ae;p=platform%2Fupstream%2Fgst-plugins-good.git

baseparse: remove checks for buffer==NULL

Accordifn to docs for GstPadChainFunction buffer cannot be NULL. If we would
leave the check, we would also need more such check below.
---

diff --git a/gst/aacparse/gstbaseparse.c b/gst/aacparse/gstbaseparse.c
index baa56826c..5f9a949ee 100644
--- a/gst/aacparse/gstbaseparse.c
+++ b/gst/aacparse/gstbaseparse.c
@@ -838,7 +838,7 @@ gst_base_parse_chain (GstPad * pad, GstBuffer * buffer)
   parse = GST_BASE_PARSE (GST_OBJECT_PARENT (pad));
   bclass = GST_BASE_PARSE_GET_CLASS (parse);
 
-  if (parse->pending_segment) {
+  if (G_UNLIKELY (parse->pending_segment)) {
     GST_DEBUG_OBJECT (parse, "chain pushing a pending segment");
     gst_pad_push_event (parse->srcpad, parse->pending_segment);
     parse->pending_segment = NULL;
@@ -854,7 +854,7 @@ gst_base_parse_chain (GstPad * pad, GstBuffer * buffer)
     gst_adapter_clear (parse->adapter);
   }
 
-  if (parse->priv->pending_events) {
+  if (G_UNLIKELY (parse->priv->pending_events)) {
     GList *l;
 
     for (l = parse->priv->pending_events; l != NULL; l = l->next) {
@@ -864,13 +864,9 @@ gst_base_parse_chain (GstPad * pad, GstBuffer * buffer)
     parse->priv->pending_events = NULL;
   }
 
-  if (buffer) {
-    GST_LOG_OBJECT (parse, "buffer size: %d, offset = %lld",
-        GST_BUFFER_SIZE (buffer), GST_BUFFER_OFFSET (buffer));
-
-
-    gst_adapter_push (parse->adapter, buffer);
-  }
+  GST_LOG_OBJECT (parse, "buffer size: %d, offset = %lld",
+      GST_BUFFER_SIZE (buffer), GST_BUFFER_OFFSET (buffer));
+  gst_adapter_push (parse->adapter, buffer);
 
   /* Parse and push as many frames as possible */
   /* Stop either when adapter is empty or we are flushing */