From: Vatsala Narang Date: Sat, 27 Apr 2019 16:07:49 +0000 (+0530) Subject: staging: vc04_services: bcm2835-camera: Modify return statement. X-Git-Tag: v5.4-rc1~1076^2~20 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=675c8a46a8cc8a15f64863fd4c7786df2b5b728b;p=platform%2Fkernel%2Flinux-rpi.git staging: vc04_services: bcm2835-camera: Modify return statement. Modify return statement and remove the respective assignment. Issue found by Coccinelle. Signed-off-by: Vatsala Narang Acked-by: Stefan Wahren Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index 2e0a422..9841c30 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -270,11 +270,9 @@ static int ctrl_set_rotate(struct bm2835_mmal_dev *dev, if (ret < 0) return ret; - ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2], + return vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2], mmal_ctrl->mmal_id, &u32_value, sizeof(u32_value)); - - return ret; } static int ctrl_set_flip(struct bm2835_mmal_dev *dev, @@ -313,11 +311,9 @@ static int ctrl_set_flip(struct bm2835_mmal_dev *dev, if (ret < 0) return ret; - ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2], + return vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2], mmal_ctrl->mmal_id, &u32_value, sizeof(u32_value)); - - return ret; } static int ctrl_set_exposure(struct bm2835_mmal_dev *dev,