From: zhong jiang Date: Thu, 20 Sep 2018 09:37:45 +0000 (+0800) Subject: net: cxgb3_main: remove redundant null pointer check before kfree_skb X-Git-Tag: v5.4-rc1~2266^2~303^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=673eed0c18341383ee0b5131935185f6f2bd6278;p=platform%2Fkernel%2Flinux-rpi.git net: cxgb3_main: remove redundant null pointer check before kfree_skb kfree_skb has taken the null pointer into account. hence it is safe to remove the redundant null pointer check before kfree_skb. Signed-off-by: zhong jiang Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index 921dd71..8b0a253 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c @@ -3422,8 +3422,7 @@ static void remove_one(struct pci_dev *pdev) free_netdev(adapter->port[i]); iounmap(adapter->regs); - if (adapter->nofail_skb) - kfree_skb(adapter->nofail_skb); + kfree_skb(adapter->nofail_skb); kfree(adapter); pci_release_regions(pdev); pci_disable_device(pdev);