From: Fedor Indutny Date: Fri, 27 Sep 2013 19:47:13 +0000 (+0400) Subject: tls: fix sporadic hang and partial reads X-Git-Tag: v0.10.20~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=671b5be6e9d74fec9e94b1ab88d2b2648c540078;p=platform%2Fupstream%2Fnodejs.git tls: fix sporadic hang and partial reads Do not decrement size in read loop, its used later, when comparing to `bytesRead`. fix #6270 NOTE: Original patch contributed by @roadrunner2 --- diff --git a/lib/tls.js b/lib/tls.js index a758c8e..fe94a51 100644 --- a/lib/tls.js +++ b/lib/tls.js @@ -447,10 +447,9 @@ CryptoStream.prototype._read = function read(size) { var bytesRead = 0, start = this._buffer.offset; do { - var read = this._buffer.use(this.pair.ssl, out, size); + var read = this._buffer.use(this.pair.ssl, out, size - bytesRead); if (read > 0) { bytesRead += read; - size -= read; } // Handle and report errors