From: DongHun Kwak Date: Fri, 15 Apr 2022 00:08:21 +0000 (+0900) Subject: feat: Improve ubidi unittest coverage X-Git-Tag: accepted/tizen/unified/20220530.140619~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=670e0bc3b5d824e1bfe669cf09537aba89d20412;p=platform%2Fcore%2Fapi%2Fbase-utils.git feat: Improve ubidi unittest coverage - remove check_current_locale() Change-Id: Ie6aad627c7d961d6b5c626a38929dc7e05422c87 --- diff --git a/tests/utc-capi-base-utils-ubidi.c b/tests/utc-capi-base-utils-ubidi.c index 5dc43a1..dcfd54b 100644 --- a/tests/utc-capi-base-utils-ubidi.c +++ b/tests/utc-capi-base-utils-ubidi.c @@ -30,33 +30,19 @@ static int32_t src_length = -1; static int32_t dst_size = -1; static int ret = 0; -static int check_current_locale() -{ - const char *loc = NULL; - i18n_ulocale_get_default(&loc); - - if (strcmp(loc, "en_US_POSIX") == 0) - return 1; - else - return 0; - -} - -static i18n_uchar_direction_e new_class_cb(const void* context, i18n_uchar32 c) +static i18n_uchar_direction_e new_class_cb(const void *context, i18n_uchar32 c) { i18n_uchar_direction_e custom_classes[] = { - R, R, R, R, R, R, R, R, - L, L, L, L, L, L, L, L - }; + R, R, R, R, R, R, R, R, + L, L, L, L, L, L, L, L}; return c >= 16 ? I18N_UBIDI_CLASS_DEFAULT : custom_classes[c]; } -static i18n_uchar_direction_e old_class_cb(const void* context, i18n_uchar32 c) +static i18n_uchar_direction_e old_class_cb(const void *context, i18n_uchar32 c) { i18n_uchar_direction_e custom_classes[] = { - R, L - }; + R, L}; return c >= 2 ? I18N_UBIDI_CLASS_DEFAULT : custom_classes[c]; } @@ -85,11 +71,11 @@ void utc_capi_base_utils_ubidi_startup(void) src_length = get_uchar_length(test_string); - src = (i18n_uchar *) malloc(sizeof(i18n_uchar) * (src_length + 1)); + src = (i18n_uchar *)malloc(sizeof(i18n_uchar) * (src_length + 1)); i18n_ustring_copy_ua(src, test_string); dst_size = src_length + 1; - dst = (i18n_uchar *) malloc(sizeof(i18n_uchar) * (dst_size)); + dst = (i18n_uchar *)malloc(sizeof(i18n_uchar) * (dst_size)); ret |= i18n_ubidi_set_para(ubidi, src, src_length, I18N_UBIDI_DEFAULT_LTR, NULL); ret |= i18n_ubidi_set_reordering_options(ubidi, I18N_UBIDI_OPTION_DEFAULT); @@ -105,12 +91,12 @@ void utc_capi_base_utils_ubidi_startup(void) */ void utc_capi_base_utils_ubidi_cleanup(void) { - if(ubidi != NULL) + if (ubidi != NULL) { i18n_ubidi_destroy(ubidi); ubidi = NULL; } - if(ubidi_line != NULL) + if (ubidi_line != NULL) { i18n_ubidi_destroy(ubidi_line); ubidi_line = NULL; @@ -135,9 +121,6 @@ int utc_capi_base_utils_i18n_ubidi_write_reverse_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - uint16_t options = I18N_UBIDI_DO_MIRRORING; int32_t output_length = -1; @@ -166,9 +149,6 @@ int utc_capi_base_utils_i18n_ubidi_write_reverse_p2(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - uint16_t options = I18N_UBIDI_KEEP_BASE_COMBINING; int32_t output_length = -1; @@ -308,9 +288,6 @@ int utc_capi_base_utils_i18n_ubidi_write_reordered_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - uint16_t options = I18N_UBIDI_KEEP_BASE_COMBINING; int32_t output_length = -1; @@ -521,9 +498,6 @@ int utc_capi_base_utils_i18n_ubidi_set_para_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - char test_text[] = " <اختبار> test"; /* Create new text */ @@ -631,9 +605,6 @@ int utc_capi_base_utils_i18n_ubidi_set_line_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - i18n_ubidi_level_t valid_levels[] = {0, 0, 0, 0, 1, 1}; ret = i18n_ubidi_create(&ubidi_line); @@ -652,7 +623,7 @@ int utc_capi_base_utils_i18n_ubidi_set_line_p(void) assert_eq(ret, I18N_ERROR_NONE); int i; - for(i = 0; i < processed_length; ++i) + for (i = 0; i < processed_length; ++i) { assert_eq(levels[i], valid_levels[i]); } @@ -893,13 +864,10 @@ int utc_capi_base_utils_i18n_ubidi_set_context_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - char test_prologue[] = "اختبار"; int32_t pro_length = get_uchar_length(test_prologue); - prologue = (i18n_uchar *) malloc(sizeof(i18n_uchar) * (pro_length + 1)); + prologue = (i18n_uchar *)malloc(sizeof(i18n_uchar) * (pro_length + 1)); i18n_ustring_copy_ua(prologue, test_prologue); ret = i18n_ubidi_set_context(ubidi, prologue, pro_length, NULL, 0); @@ -943,13 +911,10 @@ int utc_capi_base_utils_i18n_ubidi_set_context_p2(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - char test_prologue[] = "Test"; int32_t pro_length = get_uchar_length(test_prologue); - prologue = (i18n_uchar *) malloc(sizeof(i18n_uchar) * (pro_length + 1)); + prologue = (i18n_uchar *)malloc(sizeof(i18n_uchar) * (pro_length + 1)); i18n_ustring_copy_ua(prologue, test_prologue); ret = i18n_ubidi_set_context(ubidi, prologue, pro_length, NULL, 0); @@ -1030,7 +995,7 @@ int utc_capi_base_utils_i18n_ubidi_set_context_n2(void) int utc_capi_base_utils_i18n_ubidi_set_context_n3(void) { assert_eq(ret, I18N_ERROR_NONE); - prologue = (i18n_uchar *) malloc(sizeof(i18n_uchar) * (BUFLEN)); + prologue = (i18n_uchar *)malloc(sizeof(i18n_uchar) * (BUFLEN)); i18n_ustring_copy_ua(prologue, "Prologue"); int32_t pro_length = -2; // Invalid parameter @@ -1072,7 +1037,7 @@ int utc_capi_base_utils_i18n_ubidi_set_context_n5(void) assert_eq(ret, I18N_ERROR_NONE); int32_t pro_length = 0; - i18n_uchar *epilogue = (i18n_uchar *) malloc(sizeof(i18n_uchar) * (BUFLEN)); + i18n_uchar *epilogue = (i18n_uchar *)malloc(sizeof(i18n_uchar) * (BUFLEN)); i18n_ustring_copy_ua(epilogue, "Epilogue"); int32_t epi_length = -2; // Invalid parameter @@ -1169,7 +1134,7 @@ int utc_capi_base_utils_i18n_ubidi_reorder_visual_p(void) assert_eq(ret, I18N_ERROR_NONE); int i; - for(i = 0; i < length; ++i) + for (i = 0; i < length; ++i) { assert_eq(index_map[i], valid_index_map[i]); } @@ -1249,7 +1214,7 @@ int utc_capi_base_utils_i18n_ubidi_reorder_logical_p(void) assert_eq(ret, I18N_ERROR_NONE); int i; - for(i = 0; i < length; ++i) + for (i = 0; i < length; ++i) { assert_eq(index_map[i], valid_index_map[i]); } @@ -1620,13 +1585,13 @@ int utc_capi_base_utils_i18n_ubidi_invert_map_p(void) int32_t valid_dst_map[] = {0, 1, -1, -1, 6, 5, 4, -1, -1, 8, -1, 2, 3, 7}; int32_t dst_length = 14; - int32_t dst_map[dst_length+1]; + int32_t dst_map[dst_length + 1]; ret = i18n_ubidi_invert_map(src_map, length, dst_map); assert_eq(ret, I18N_ERROR_NONE); int i; - for(i = 0; i < dst_length; ++i) + for (i = 0; i < dst_length; ++i) { assert_eq(dst_map[i], valid_dst_map[i]); } @@ -1643,7 +1608,7 @@ int utc_capi_base_utils_i18n_ubidi_invert_map_p(void) int utc_capi_base_utils_i18n_ubidi_invert_map_n(void) { int32_t dst_length = 14; - int32_t dst_map[dst_length+1]; + int32_t dst_map[dst_length + 1]; int32_t length = 10; ret = i18n_ubidi_invert_map(NULL, length, dst_map); @@ -1662,7 +1627,7 @@ int utc_capi_base_utils_i18n_ubidi_invert_map_n2(void) { int32_t src_map[] = {0, 1, 11, 12, 6, 5, 4, 13, 9, -1}; int32_t dst_length = 14; - int32_t dst_map[dst_length+1]; + int32_t dst_map[dst_length + 1]; int32_t length = -2; // Invalid parameter ret = i18n_ubidi_invert_map(src_map, length, dst_map); @@ -1679,7 +1644,8 @@ int utc_capi_base_utils_i18n_ubidi_invert_map_n2(void) */ int utc_capi_base_utils_i18n_ubidi_invert_map_n3(void) { - int32_t src_map[] = {0, 1, 11, 12, 6, 5, 4, 13, 9, -1};; + int32_t src_map[] = {0, 1, 11, 12, 6, 5, 4, 13, 9, -1}; + ; int32_t length = 10; ret = i18n_ubidi_invert_map(src_map, length, NULL); @@ -1697,20 +1663,17 @@ int utc_capi_base_utils_i18n_ubidi_get_visual_run_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - int logical_ind[] = {0, 14, 20, 47, 53}; int length[] = {14, 6, 27, 6, 12}; i18n_ubidi_direction_e dir[] = {I18N_UBIDI_LTR, I18N_UBIDI_RTL, - I18N_UBIDI_LTR, I18N_UBIDI_RTL, I18N_UBIDI_LTR}; + I18N_UBIDI_LTR, I18N_UBIDI_RTL, I18N_UBIDI_LTR}; int runs_counter = -1; ret = i18n_ubidi_count_runs(ubidi, &runs_counter); assert_eq(ret, I18N_ERROR_NONE); int32_t run_index; - for(run_index = 0; run_index < runs_counter; ++run_index) + for (run_index = 0; run_index < runs_counter; ++run_index) { int32_t p_logical_index = -1; int32_t p_length = -1; @@ -1756,7 +1719,7 @@ int utc_capi_base_utils_i18n_ubidi_get_visual_run_n2(void) { assert_eq(ret, I18N_ERROR_NONE); - int32_t run_index = -2; //Invalid parameter + int32_t run_index = -2; // Invalid parameter i18n_ubidi_direction_e direction = I18N_UBIDI_LTR; ret = i18n_ubidi_get_visual_run(ubidi, run_index, NULL, NULL, &direction); @@ -1792,9 +1755,6 @@ int utc_capi_base_utils_i18n_ubidi_get_visual_map_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - int32_t valid_map[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 19, 18, 17, 16, 15, 14, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, @@ -1812,7 +1772,7 @@ int utc_capi_base_utils_i18n_ubidi_get_visual_map_p(void) assert_eq(ret, I18N_ERROR_NONE); int i; - for(i = 0; i < length; ++i) + for (i = 0; i < length; ++i) { assert_eq(index_map[i], valid_map[i]); } @@ -1865,9 +1825,6 @@ int utc_capi_base_utils_i18n_ubidi_get_visual_index_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - int32_t valid_map[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 19, 18, 17, 16, 15, 14, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, @@ -1881,7 +1838,7 @@ int utc_capi_base_utils_i18n_ubidi_get_visual_index_p(void) assert_eq(ret, I18N_ERROR_NONE); int i; - for(i = 0; i < length; ++i) + for (i = 0; i < length; ++i) { int32_t visual_index = -1; ret = i18n_ubidi_get_visual_index(ubidi, i, &visual_index); @@ -1959,9 +1916,6 @@ int utc_capi_base_utils_i18n_ubidi_get_text_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - char *text = NULL; ret = i18n_ubidi_get_text(ubidi, &text); @@ -2008,7 +1962,6 @@ int utc_capi_base_utils_i18n_ubidi_get_text_n2(void) return 0; } - /** * @testcase utc_capi_base_utils_i18n_ubidi_get_text_n3 * @since_tizen 3.0 @@ -2258,9 +2211,6 @@ int utc_capi_base_utils_i18n_ubidi_get_para_level_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - i18n_ubidi_level_t level = 1; ret = i18n_ubidi_get_para_level(ubidi, &level); @@ -2279,13 +2229,10 @@ int utc_capi_base_utils_i18n_ubidi_get_para_level_p2(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - free(src); char test_text[] = "اختبار paragraph1"; src_length = get_uchar_length(test_text); - src = (i18n_uchar *) malloc(sizeof(i18n_uchar) * (src_length + 1)); + src = (i18n_uchar *)malloc(sizeof(i18n_uchar) * (src_length + 1)); i18n_ustring_copy_ua(src, test_text); ret = i18n_ubidi_set_para(ubidi, src, src_length, I18N_UBIDI_DEFAULT_LTR, NULL); @@ -2344,9 +2291,6 @@ int utc_capi_base_utils_i18n_ubidi_get_paragraph_by_index_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - int32_t valid_para_start[] = {0, 33}; int32_t valid_para_limit[] = {33, 65}; i18n_ubidi_level_t valid_para_level[] = {0, 0}; @@ -2356,7 +2300,7 @@ int utc_capi_base_utils_i18n_ubidi_get_paragraph_by_index_p(void) assert_eq(ret, I18N_ERROR_NONE); int32_t para_index; - for(para_index = 0; para_index < count; ++para_index) + for (para_index = 0; para_index < count; ++para_index) { int32_t p_para_start = -1; int32_t p_para_limit = -1; @@ -2417,9 +2361,6 @@ int utc_capi_base_utils_i18n_ubidi_get_paragraph_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - int32_t valid_para_start[] = {0, 33}; int32_t valid_para_limit[] = {33, 65}; i18n_ubidi_level_t valid_para_level[] = {0, 0}; @@ -2429,7 +2370,7 @@ int utc_capi_base_utils_i18n_ubidi_get_paragraph_p(void) assert_eq(ret, I18N_ERROR_NONE); int32_t char_index; - for(char_index = 0; char_index < length; ++char_index) + for (char_index = 0; char_index < length; ++char_index) { int32_t paragraph_index = -1; int32_t p_para_start = -1; @@ -2514,9 +2455,6 @@ int utc_capi_base_utils_i18n_ubidi_get_logical_run_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - int valid_p_logical_position[] = {14, 14, 14, 14, 14, 14, 14, 14, 14, 14, 14, 14, 14, 14, 20, 20, 20, 20, 20, 20, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, 47, @@ -2535,7 +2473,7 @@ int utc_capi_base_utils_i18n_ubidi_get_logical_run_p(void) assert_eq(ret, I18N_ERROR_NONE); int32_t logical_position; - for(logical_position = 0; logical_position < processed_length; ++logical_position) + for (logical_position = 0; logical_position < processed_length; ++logical_position) { int32_t p_logical_position = -2; i18n_ubidi_level_t level = 2; @@ -2578,9 +2516,6 @@ int utc_capi_base_utils_i18n_ubidi_get_logical_map_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - int32_t valid_map[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 19, 18, 17, 16, 15, 14, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, @@ -2598,7 +2533,7 @@ int utc_capi_base_utils_i18n_ubidi_get_logical_map_p(void) assert_eq(ret, I18N_ERROR_NONE); int i; - for(i = 0; i < length; ++i) + for (i = 0; i < length; ++i) { assert_eq(index_map[i], valid_map[i]); } @@ -2654,9 +2589,6 @@ int utc_capi_base_utils_i18n_ubidi_get_logical_index_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - int32_t valid_map[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 19, 18, 17, 16, 15, 14, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, @@ -2670,7 +2602,7 @@ int utc_capi_base_utils_i18n_ubidi_get_logical_index_p(void) assert_eq(ret, I18N_ERROR_NONE); int i; - for(i = 0; i < length; ++i) + for (i = 0; i < length; ++i) { int32_t logical_index = -1; ret = i18n_ubidi_get_logical_index(ubidi, i, &logical_index); @@ -2747,9 +2679,6 @@ int utc_capi_base_utils_i18n_ubidi_get_levels_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - i18n_ubidi_level_t valid_levels[] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, @@ -2767,7 +2696,7 @@ int utc_capi_base_utils_i18n_ubidi_get_levels_p(void) assert_eq(ret, I18N_ERROR_NONE); int32_t char_index; - for(char_index = 0; char_index < processed_length; ++char_index) + for (char_index = 0; char_index < processed_length; ++char_index) { assert_eq(levels[char_index], valid_levels[char_index]); } @@ -2818,9 +2747,6 @@ int utc_capi_base_utils_i18n_ubidi_get_level_at_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - i18n_ubidi_level_t valid_levels[] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, @@ -2834,14 +2760,14 @@ int utc_capi_base_utils_i18n_ubidi_get_level_at_p(void) int32_t char_index; i18n_ubidi_level_t levels[processed_length]; - for(char_index = 0; char_index < processed_length; ++char_index) + for (char_index = 0; char_index < processed_length; ++char_index) { ret = i18n_ubidi_get_level_at(ubidi, char_index, &levels[char_index]); assert_eq(ret, I18N_ERROR_NONE); } int i; - for(i = 0; i < processed_length; ++i) + for (i = 0; i < processed_length; ++i) { assert_eq(levels[i], valid_levels[i]); } @@ -2948,9 +2874,6 @@ int utc_capi_base_utils_i18n_ubidi_get_direction_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - i18n_ubidi_direction_e direction = I18N_UBIDI_LTR; ret = i18n_ubidi_get_direction(ubidi, &direction); @@ -3203,9 +3126,6 @@ int utc_capi_base_utils_i18n_ubidi_count_runs_p(void) { assert_eq(ret, I18N_ERROR_NONE); - if (check_current_locale()) - return 0; - int32_t count = -1; ret = i18n_ubidi_count_runs(ubidi, &count);