From: Gustavo A. R. Silva Date: Sat, 25 Jul 2020 12:00:19 +0000 (+0800) Subject: bcache: movinggc: Use struct_size() helper in kzalloc() X-Git-Tag: v5.15~3211^2~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6706ad56436c9d54c9e5812aabe25186b43b4199;p=platform%2Fkernel%2Flinux-starfive.git bcache: movinggc: Use struct_size() helper in kzalloc() Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Coly Li Signed-off-by: Jens Axboe --- diff --git a/drivers/md/bcache/movinggc.c b/drivers/md/bcache/movinggc.c index 7891fb5..b7dd2d7 100644 --- a/drivers/md/bcache/movinggc.c +++ b/drivers/md/bcache/movinggc.c @@ -145,8 +145,8 @@ static void read_moving(struct cache_set *c) continue; } - io = kzalloc(sizeof(struct moving_io) + sizeof(struct bio_vec) - * DIV_ROUND_UP(KEY_SIZE(&w->key), PAGE_SECTORS), + io = kzalloc(struct_size(io, bio.bio.bi_inline_vecs, + DIV_ROUND_UP(KEY_SIZE(&w->key), PAGE_SECTORS)), GFP_KERNEL); if (!io) goto err;