From: Michael Gottesman Date: Thu, 21 Jul 2016 21:35:23 +0000 (+0000) Subject: [cmake] Move the including of utils/unittests under LLVM_INCLUDE_UTILS instead of... X-Git-Tag: llvmorg-4.0.0-rc1~14573 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=66ddd15e869789eaa3a611e9b0c4021d71d187e5;p=platform%2Fupstream%2Fllvm.git [cmake] Move the including of utils/unittests under LLVM_INCLUDE_UTILS instead of LLVM_INCLUDE_TESTS. This does not change anything by default since LLVM_INCLUDE_UTILS is already set to TRUE by default. In addition, since LLVM_INCLUDE_TESTS => LLVM_INCLUDE_UTILS, the only way that this can cause changes is in the case where LLVM_INCLUDE_UTILS is set to TRUE, but LLVM_INCLUDE_TESTS is FALSE. In that case, building gtest is not a huge cost. The reason to do this is that without this change, one can not turn off LLVM_INCLUDE_TESTS in downstream projects that also use gtest for unittests. It also just in general makes more sense since LLVM_INCLUDE_UTILS gates FileCheck and other utilities that are along the lines of gtest. Additionally from talking with chandlerc, this was not done for any specific reason, so there is no reason not to do it and lots of benefit to doing it. llvm-svn: 276342 --- diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt index 20e9f53..d145936 100644 --- a/llvm/CMakeLists.txt +++ b/llvm/CMakeLists.txt @@ -722,6 +722,7 @@ if( LLVM_INCLUDE_UTILS ) add_subdirectory(utils/not) add_subdirectory(utils/llvm-lit) add_subdirectory(utils/yaml-bench) + add_subdirectory(utils/unittest) else() if ( LLVM_INCLUDE_TESTS ) message(FATAL_ERROR "Including tests when not building utils will not work. @@ -734,10 +735,6 @@ if (LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION) add_subdirectory(utils/LLVMVisualizers) endif() -if(LLVM_INCLUDE_TESTS) - add_subdirectory(utils/unittest) -endif() - foreach( binding ${LLVM_BINDINGS_LIST} ) if( EXISTS "${LLVM_MAIN_SRC_DIR}/bindings/${binding}/CMakeLists.txt" ) add_subdirectory(bindings/${binding})