From: Zhen Lei <thunder.leizhen@huawei.com>
Date: Tue, 30 Aug 2022 11:28:55 +0000 (+0800)
Subject: livepatch: Add a missing newline character in klp_module_coming()
X-Git-Tag: v6.1-rc5~237^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=66d8529d0f0423bc0fc249a5620c342c122981fb;p=platform%2Fkernel%2Flinux-starfive.git

livepatch: Add a missing newline character in klp_module_coming()

The error message is not printed immediately because it does not end with
a newline character.

Before:
root@localhost:~# insmod vmlinux.ko
insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters

After:
root@localhost:~# insmod vmlinux.ko
[   43.982558] livepatch: vmlinux.ko: invalid module name
insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters

Fixes: dcf550e52f56 ("livepatch: Disallow vmlinux.ko")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20220830112855.749-1-thunder.leizhen@huawei.com
---

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index bc475e62279d..42f7e716d56b 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -1171,7 +1171,7 @@ int klp_module_coming(struct module *mod)
 		return -EINVAL;
 
 	if (!strcmp(mod->name, "vmlinux")) {
-		pr_err("vmlinux.ko: invalid module name");
+		pr_err("vmlinux.ko: invalid module name\n");
 		return -EINVAL;
 	}