From: Colin Walters <walters@verbum.org>
Date: Mon, 5 Jan 2015 14:40:37 +0000 (-0500)
Subject: gdbusconnection: Don't g_printerr() when exiting
X-Git-Tag: upstream/2.48.0^2~10
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=66bc9660c44b71c8bff47b4f7e16a801169a9f23;p=platform%2Fupstream%2Fglib.git

gdbusconnection: Don't g_printerr() when exiting

exit-on-close for a DBus connection is a completely normal thing.  On
a regular GNOME login, gdm retains the X server, but terminates the
session login bus and associated helpers like gnome-settings-dameon,
the a11y tools, etc.

I've seen several downstream reports of confusion as to what these
apparent error messages mean in the system log.  It doesn't help
that they're so obtuse.

We're also printing them to stderr, when this is not an error.

The reason this was introduced is presumably some people were confused
as to why their process exited when the system bus did.  But the
solution for that I believe is documentation, not printing stuff to
everyone's system log in normal operation.

https://bugzilla.gnome.org/show_bug.cgi?id=742386
---

diff --git a/gio/gdbusconnection.c b/gio/gdbusconnection.c
index 7b71bd0..9824ad9 100644
--- a/gio/gdbusconnection.c
+++ b/gio/gdbusconnection.c
@@ -804,17 +804,6 @@ g_dbus_connection_real_closed (GDBusConnection *connection,
       (flags & FLAG_INITIALIZED) != 0 &&
       connection->initialization_error == NULL)
     {
-      if (error != NULL)
-        {
-          g_printerr ("%s: Remote peer vanished with error: %s (%s, %d). Exiting.\n",
-                      G_STRFUNC,
-                      error->message,
-                      g_quark_to_string (error->domain), error->code);
-        }
-      else
-        {
-          g_printerr ("%s: Remote peer vanished. Exiting.\n", G_STRFUNC);
-        }
       raise (SIGTERM);
     }
 }