From: Ajay Singh <ajay.kathat@microchip.com>
Date: Wed, 25 Nov 2020 11:41:09 +0000 (+0000)
Subject: wilc1000: free resource in wilc_wlan_txq_add_mgmt_pkt() for failure path
X-Git-Tag: v5.15~2222^2~122^2~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=66aea5d198c3ad4434e6adfb66dcb574c9a14779;p=platform%2Fkernel%2Flinux-starfive.git

wilc1000: free resource in wilc_wlan_txq_add_mgmt_pkt() for failure path

Before returing from wilc_wlan_txq_add_mgmt_pkt() invoke tx_complete_fn()
callback to free up allocated memory for failure case.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201125114059.10006-4-ajay.kathat@microchip.com
---

diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
index f0cc2da..42b5db4 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.c
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -319,13 +319,17 @@ int wilc_wlan_txq_add_mgmt_pkt(struct net_device *dev, void *priv, u8 *buffer,
 
 	wilc = vif->wilc;
 
-	if (wilc->quit)
+	if (wilc->quit) {
+		tx_complete_fn(priv, 0);
 		return 0;
+	}
 
 	tqe = kmalloc(sizeof(*tqe), GFP_ATOMIC);
 
-	if (!tqe)
+	if (!tqe) {
+		tx_complete_fn(priv, 0);
 		return 0;
+	}
 	tqe->type = WILC_MGMT_PKT;
 	tqe->buffer = buffer;
 	tqe->buffer_size = buffer_size;