From: Wei Yongjun Date: Sun, 21 May 2017 01:01:52 +0000 (+0000) Subject: drm/pl111: Fix return value check in pl111_amba_probe() X-Git-Tag: v4.14-rc1~8^2~52^2~244 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=665f37e7eec33223bdc50cc1b3e00bca97a30aea;p=platform%2Fkernel%2Flinux-rpi.git drm/pl111: Fix return value check in pl111_amba_probe() In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") Signed-off-by: Wei Yongjun Reviewed-by: Eric Anholt Link: http://patchwork.freedesktop.org/patch/msgid/20170521010152.6186-1-weiyj.lk@gmail.com --- diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c index 97095b1aa961..e96efad37d27 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -200,9 +200,9 @@ static int pl111_amba_probe(struct amba_device *amba_dev, drm->dev_private = priv; priv->regs = devm_ioremap_resource(dev, &amba_dev->res); - if (!priv->regs) { + if (IS_ERR(priv->regs)) { dev_err(dev, "%s failed mmio\n", __func__); - return -EINVAL; + return PTR_ERR(priv->regs); } /* turn off interrupts before requesting the irq */