From: YANG LI Date: Mon, 11 Jan 2021 09:26:29 +0000 (+0800) Subject: spi: spi-bcm-qspi: style: Simplify bool comparison X-Git-Tag: v5.15~939^2~100^2~41 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6650ab2a44268af8d24995d28ae199b57b2ebff8;p=platform%2Fkernel%2Flinux-starfive.git spi: spi-bcm-qspi: style: Simplify bool comparison Fix the following coccicheck warning: ./drivers/spi/spi-bcm-qspi.c:884:5-34: WARNING: Comparison to bool Signed-off-by: YANG LI Reported-by: Abaci Robot Link: https://lore.kernel.org/r/1610357189-60031-1-git-send-email-abaci-bugfix@linux.alibaba.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c index c028446..707fe3a 100644 --- a/drivers/spi/spi-bcm-qspi.c +++ b/drivers/spi/spi-bcm-qspi.c @@ -881,7 +881,7 @@ static int bcm_qspi_bspi_exec_mem_op(struct spi_device *spi, * when using flex mode we need to send * the upper address byte to bspi */ - if (bcm_qspi_bspi_ver_three(qspi) == false) { + if (!bcm_qspi_bspi_ver_three(qspi)) { addr = from & 0xff000000; bcm_qspi_write(qspi, BSPI, BSPI_BSPI_FLASH_UPPER_ADDR_BYTE, addr);