From: Yunjin Lee <yunjin-.lee@samsung.com>
Date: Fri, 26 Jan 2018 07:38:36 +0000 (+0900)
Subject: Fix to finalize DB when exception occurred
X-Git-Tag: submit/tizen/20180227.081154~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6630d88b25927d99bc8993b6c1dedb0540a355ee;p=platform%2Fcore%2Fsecurity%2Fprivilege-checker.git

Fix to finalize DB when exception occurred

Change-Id: I4416b5246f5ad8ee543a671a5d45e2fdaa59a795
Signed-off-by: Yunjin Lee <yunjin-.lee@samsung.com>
---

diff --git a/capi/src/privilege_db_manager.c b/capi/src/privilege_db_manager.c
index d7a6d2b..cdf5cab 100755
--- a/capi/src/privilege_db_manager.c
+++ b/capi/src/privilege_db_manager.c
@@ -434,6 +434,7 @@ int privilege_db_manager_is(char type, const char* privilege)
 		break;
 	default:
 		_LOGE("Undefined type for privilege_db_manager_is()");
+		__finalize_db(db, stmt, sql);
 		return PRIVILEGE_DB_MANAGER_ERR_INVALID_TYPE;
 	}
 	TryReturn(sql != NULL, __finalize_db(db, stmt, sql), PRIVILEGE_DB_MANAGER_ERR_INVALID_QUERY, "[DB_FAIL] sqlite3_mprintf failed");
@@ -450,9 +451,6 @@ int privilege_db_manager_is(char type, const char* privilege)
 		case 'i':
 			res = sqlite3_column_int(stmt, 0);
 			break;
-		default:
-			_LOGE("Undefined type for privilege_db_manager_is()");
-			return PRIVILEGE_DB_MANAGER_ERR_INVALID_TYPE;
 		}
 	} else if (ret == SQLITE_DONE) {
 		_LOGD("[PRIVILEGE_DB_MANAGER] NO DATA TO READ. %s is invalid privilege. ret = %d", privilege, ret);