From: Takashi Iwai Date: Mon, 26 Jul 2021 06:26:56 +0000 (+0200) Subject: ALSA: usb-audio: Fix superfluous autosuspend recovery X-Git-Tag: accepted/tizen/unified/20230118.172025~6638^2~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=66291b6adb66dd3bc96b0f594d88c2ff1300d95f;p=platform%2Fkernel%2Flinux-rpi.git ALSA: usb-audio: Fix superfluous autosuspend recovery The change to restore the autosuspend from the disabled state uses a wrong check: namely, it should have been the exact comparison of the quirk_type instead of the bitwise and (&). Otherwise it matches wrongly with the other quirk types. Although re-enabling the autosuspend for the already enabled device shouldn't matter much, it's better to fix the unbalanced call. Fixes: 9799110825db ("ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()") Cc: Link: https://lore.kernel.org/r/s5hr1flh9ov.wl-tiwai@suse.de Signed-off-by: Takashi Iwai --- diff --git a/sound/usb/card.c b/sound/usb/card.c index 2f6a624..a1f8c3a 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -907,7 +907,7 @@ static void usb_audio_disconnect(struct usb_interface *intf) } } - if (chip->quirk_type & QUIRK_SETUP_DISABLE_AUTOSUSPEND) + if (chip->quirk_type == QUIRK_SETUP_DISABLE_AUTOSUSPEND) usb_enable_autosuspend(interface_to_usbdev(intf)); chip->num_interfaces--;