From: Christoph Hellwig Date: Thu, 25 Apr 2019 07:04:34 +0000 (+0200) Subject: block: remove bogus comments in __bio_add_pc_page X-Git-Tag: v5.15~6320^2~48 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6601e44efd20efddc183c85131216200e90c5728;p=platform%2Fkernel%2Flinux-starfive.git block: remove bogus comments in __bio_add_pc_page We are never called with file system pages by defintions for the passthrough interface, and we also never undo any addition later these days. Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe --- diff --git a/block/bio.c b/block/bio.c index e717b30..de26dc1 100644 --- a/block/bio.c +++ b/block/bio.c @@ -724,11 +724,6 @@ static int __bio_add_pc_page(struct request_queue *q, struct bio *bio, if (((bio->bi_iter.bi_size + len) >> 9) > queue_max_hw_sectors(q)) return 0; - /* - * For filesystems with a blocksize smaller than the pagesize - * we will often be called with the same page as last time and - * a consecutive offset. Optimize this special case. - */ if (bio->bi_vcnt > 0) { bvec = &bio->bi_io_vec[bio->bi_vcnt - 1]; @@ -760,10 +755,6 @@ static int __bio_add_pc_page(struct request_queue *q, struct bio *bio, if (bio->bi_phys_segments >= queue_max_segments(q)) return 0; - /* - * setup the new entry, we might clear it again later if we - * cannot add the page - */ bvec = &bio->bi_io_vec[bio->bi_vcnt]; bvec->bv_page = page; bvec->bv_len = len;