From: Vasily Averin <vvs@virtuozzo.com>
Date: Thu, 23 Jan 2020 07:11:13 +0000 (+0300)
Subject: l2t_seq_next should increase position index
X-Git-Tag: v5.15~4702^2~7^2~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=66018a102f7756cf72db4d2704e1b93969d9d332;p=platform%2Fkernel%2Flinux-starfive.git

l2t_seq_next should increase position index

if seq_file .next fuction does not change position index,
read after some lseek can generate unexpected output.

https://bugzilla.kernel.org/show_bug.cgi?id=206283
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/chelsio/cxgb4/l2t.c b/drivers/net/ethernet/chelsio/cxgb4/l2t.c
index e9e4500..1a16449 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/l2t.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/l2t.c
@@ -678,8 +678,7 @@ static void *l2t_seq_start(struct seq_file *seq, loff_t *pos)
 static void *l2t_seq_next(struct seq_file *seq, void *v, loff_t *pos)
 {
 	v = l2t_get_idx(seq, *pos);
-	if (v)
-		++*pos;
+	++(*pos);
 	return v;
 }