From: Liang He Date: Thu, 21 Jul 2022 14:43:08 +0000 (+0800) Subject: ASoC: audio-graph-card: Add of_node_put() in fail path X-Git-Tag: v6.6.17~6759^2~6^2~29 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=65fb8e2ef3531a6e950060fca6e551c923fb0f0e;p=platform%2Fkernel%2Flinux-rpi.git ASoC: audio-graph-card: Add of_node_put() in fail path In asoc_simple_parse_dai(), we should call of_node_put() for the reference returned by of_graph_get_port_parent() in fail path. Fixes: ae30a694da4c ("ASoC: simple-card-utils: add asoc_simple_card_parse_dai()") Signed-off-by: Liang He Link: https://lore.kernel.org/r/20220721144308.1301587-1-windhl@126.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c index 2b598af8..b327372 100644 --- a/sound/soc/generic/audio-graph-card.c +++ b/sound/soc/generic/audio-graph-card.c @@ -158,8 +158,10 @@ static int asoc_simple_parse_dai(struct device_node *ep, * if he unbinded CPU or Codec. */ ret = snd_soc_get_dai_name(&args, &dlc->dai_name); - if (ret < 0) + if (ret < 0) { + of_node_put(node); return ret; + } dlc->of_node = node;