From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 23 Feb 2017 22:22:19 +0000 (-0800)
Subject: net: phy: Add missing driver check in phy_aneg_done()
X-Git-Tag: v4.11-rc1~55^2~23
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=65f2767a64ab33847d5f028661b82d8d3a4fda99;p=platform%2Fkernel%2Flinux-exynos.git

net: phy: Add missing driver check in phy_aneg_done()

Dan's static checker caught a potential code path in phy_state_machine() where
we were not checking phydev->drv which is in phy_aneg_done().

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 25149ef9d25c ("net: phy: Check phydev->drv")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index d6f7838..1be69d8 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -146,7 +146,7 @@ static int phy_config_interrupt(struct phy_device *phydev, u32 interrupts)
  */
 int phy_aneg_done(struct phy_device *phydev)
 {
-	if (phydev->drv->aneg_done)
+	if (phydev->drv && phydev->drv->aneg_done)
 		return phydev->drv->aneg_done(phydev);
 
 	return genphy_aneg_done(phydev);