From: Yuan Can Date: Sat, 26 Nov 2022 04:34:10 +0000 (+0000) Subject: RDMA/nldev: Add checks for nla_nest_start() in fill_stat_counter_qps() X-Git-Tag: v6.1.8~1307 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=65c73bc771d611d016b00cc8251640c68b22e52c;p=platform%2Fkernel%2Flinux-starfive.git RDMA/nldev: Add checks for nla_nest_start() in fill_stat_counter_qps() [ Upstream commit ea5ef136e215fdef35f14010bc51fcd6686e6922 ] As the nla_nest_start() may fail with NULL returned, the return value needs to be checked. Fixes: c4ffee7c9bdb ("RDMA/netlink: Implement counter dumpit calback") Signed-off-by: Yuan Can Link: https://lore.kernel.org/r/20221126043410.85632-1-yuancan@huawei.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c index f1e0755..54d4e69 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -894,6 +894,8 @@ static int fill_stat_counter_qps(struct sk_buff *msg, int ret = 0; table_attr = nla_nest_start(msg, RDMA_NLDEV_ATTR_RES_QP); + if (!table_attr) + return -EMSGSIZE; rt = &counter->device->res[RDMA_RESTRACK_QP]; xa_lock(&rt->xa);