From: Łukasz Stelmach <l.stelmach@samsung.com>
Date: Fri, 10 Sep 2021 18:02:53 +0000 (+0200)
Subject: logger: handle error values from filp_open()
X-Git-Tag: submit/tizen/20211126.100737~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=65c629f28ff4ab42889acbf60ddaaf5aacf5f399;p=platform%2Fkernel%2Flinux-tizen-modules-source.git

logger: handle error values from filp_open()

filp_open() may return -errno, so check for that instead of checking
for NULL.

Change-Id: I5a694555bcd082506330e08f48ed4b7043c4e120
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---

diff --git a/kernel/logger.c b/kernel/logger.c
index 202703c..eb287e4 100644
--- a/kernel/logger.c
+++ b/kernel/logger.c
@@ -484,9 +484,8 @@ static struct file *make_new_file(struct file *file)
 
 	nfile = filp_open(p, O_WRONLY, 0);
 	kfree(pbuf);
-	if (!nfile) {
-		return ERR_PTR(-EFAULT);
-	}
+	if (IS_ERR(nfile))
+		return nfile;
 
 	nwriter = nfile->private_data;
 	nwriter->prio = writer->prio;