From: Naidu Tellapati Date: Thu, 7 May 2015 21:22:19 +0000 (-0300) Subject: iio: adc: cc10001: Fix regulator_get_voltage() return value check X-Git-Tag: v5.15~15766^2^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=65a761bf8d55fdcf8ecc4642382a4e76c086e44c;p=platform%2Fkernel%2Flinux-starfive.git iio: adc: cc10001: Fix regulator_get_voltage() return value check regulator_get_voltage() returns a non-negative value in case of success, and a negative error in case of error. Let's fix this. Fixes: 1664f6a5b0c8 ("iio: adc: Cosmic Circuits 10001 ADC driver") Signed-off-by: Naidu Tellapati Signed-off-by: Ezequiel Garcia Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/adc/cc10001_adc.c b/drivers/iio/adc/cc10001_adc.c index e7810ac..fb7c5d2 100644 --- a/drivers/iio/adc/cc10001_adc.c +++ b/drivers/iio/adc/cc10001_adc.c @@ -230,7 +230,7 @@ static int cc10001_adc_read_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_SCALE: ret = regulator_get_voltage(adc_dev->reg); - if (ret) + if (ret < 0) return ret; *val = ret / 1000;