From: Pawel Wasowski Date: Wed, 27 Feb 2019 16:06:45 +0000 (+0100) Subject: [messaging][bugfix] Don't convert filter's matchValue to String X-Git-Tag: submit/tizen/20191025.073230~2^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=658f34cd98134c387bb6d30ef9812e8b0afcb85d;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git [messaging][bugfix] Don't convert filter's matchValue to String Due to a conversion of matchValue to String, filters with boolean matchValues did not match objects. [Verification] All subtest cases, dealing with boolean attributes, introduced in TCT in commit https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/199159/ passed. This commit has already been reviewed: https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200661/ Change-Id of the original change was: I72fc83328e92529455460469c5dbc1aadc6ce07e Signed-off-by: Pawel Wasowski Change-Id: Ia8d769b1a9694defdcb403761cff9c2565f5f52b --- diff --git a/src/messaging/messaging_api.js b/src/messaging/messaging_api.js index d46536e4..63764e2c 100755 --- a/src/messaging/messaging_api.js +++ b/src/messaging/messaging_api.js @@ -39,8 +39,7 @@ function addTypeToFilter_(data) { if (data instanceof tizen.AttributeFilter) { filter.filterType = 'AttributeFilter'; - //convert to string - filter.matchValue = String(filter.matchValue); + filter.matchValue = filter.matchValue; } else if (data instanceof tizen.AttributeRangeFilter) { filter.filterType = 'AttributeRangeFilter'; } else if (data instanceof tizen.CompositeFilter) {