From: Eric Dumazet Date: Sun, 19 Jun 2011 12:43:33 +0000 (+0000) Subject: hp100: fix an skb->len race X-Git-Tag: v3.12-rc1~5539^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=658924dc9ae2ca8e3c46f36306f5dbd501cf4688;p=kernel%2Fkernel-generic.git hp100: fix an skb->len race As soon as skb is given to hardware and spinlock released, TX completion can free skb under us. Therefore, we should update netdev stats before spinlock release. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller --- diff --git a/drivers/net/hp100.c b/drivers/net/hp100.c index 8e10d2f..c3ecb11 100644 --- a/drivers/net/hp100.c +++ b/drivers/net/hp100.c @@ -1580,12 +1580,12 @@ static netdev_tx_t hp100_start_xmit_bm(struct sk_buff *skb, hp100_outl(ringptr->pdl_paddr, TX_PDA_L); /* Low Prio. Queue */ lp->txrcommit++; - spin_unlock_irqrestore(&lp->lock, flags); - /* Update statistics */ dev->stats.tx_packets++; dev->stats.tx_bytes += skb->len; + spin_unlock_irqrestore(&lp->lock, flags); + return NETDEV_TX_OK; drop: