From: Pavel Machek <pavel@ucw.cz>
Date: Mon, 16 Aug 2021 06:47:08 +0000 (+0200)
Subject: leds: flash: Remove redundant initialization of variable ret
X-Git-Tag: accepted/tizen/unified/20230118.172025~6532^2~12
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=654933ae7d32f278eecd0bb0f175785574ac4775;p=platform%2Fkernel%2Flinux-rpi.git

leds: flash: Remove redundant initialization of variable ret

Adjust initialization not to trigger Coverity warnings.

Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
---

diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
index 6eeb9ef..185e170 100644
--- a/drivers/leds/led-class-flash.c
+++ b/drivers/leds/led-class-flash.c
@@ -92,14 +92,12 @@ static ssize_t flash_strobe_store(struct device *dev,
 	struct led_classdev *led_cdev = dev_get_drvdata(dev);
 	struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev);
 	unsigned long state;
-	ssize_t ret = -EINVAL;
+	ssize_t ret = -EBUSY;
 
 	mutex_lock(&led_cdev->led_access);
 
-	if (led_sysfs_is_disabled(led_cdev)) {
-		ret = -EBUSY;
+	if (led_sysfs_is_disabled(led_cdev))
 		goto unlock;
-	}
 
 	ret = kstrtoul(buf, 10, &state);
 	if (ret)