From: Monk Liu Date: Mon, 27 Mar 2017 07:14:53 +0000 (+0800) Subject: drm/amdgpu:fix the check in cs_ib_fill for SRIOV X-Git-Tag: v4.14-rc1~674^2~26^2~37 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=65333e4429c60b8bbbb7a9213cb5612761499acd;p=platform%2Fkernel%2Flinux-rpi3.git drm/amdgpu:fix the check in cs_ib_fill for SRIOV 1,the check is only appliable for SRIOV GFX engine. 2,use chunk_ib instead of ib. Signed-off-by: Monk Liu Reviewed-by: Ken Wang Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index cf44388..2957404 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -903,17 +903,18 @@ static int amdgpu_cs_ib_fill(struct amdgpu_device *adev, if (chunk->chunk_id != AMDGPU_CHUNK_ID_IB) continue; - if (ib->flags & AMDGPU_IB_FLAG_PREEMPT) { - if (ib->flags & AMDGPU_IB_FLAG_CE) - ce_preempt++; - else - de_preempt++; + if (chunk_ib->ip_type == AMDGPU_HW_IP_GFX && amdgpu_sriov_vf(adev)) { + if (chunk_ib->flags & AMDGPU_IB_FLAG_PREEMPT) + if (chunk_ib->flags & AMDGPU_IB_FLAG_CE) + ce_preempt++; + else + de_preempt++; + + /* each GFX command submit allows 0 or 1 IB preemptible for CE & DE */ + if (ce_preempt > 1 || de_preempt > 1) + BUG(); } - /* only one preemptible IB per submit for me/ce */ - if (ce_preempt > 1 || de_preempt > 1) - return -EINVAL; - r = amdgpu_cs_get_ring(adev, chunk_ib->ip_type, chunk_ib->ip_instance, chunk_ib->ring, &ring);