From: remi.denis-courmont@nokia <remi.denis-courmont@nokia>
Date: Fri, 23 Jan 2009 03:00:29 +0000 (+0000)
Subject: Phonet: remove useless locking in device cleanup
X-Git-Tag: v2.6.30-rc1~662^2~887
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6530e0fee1834fab51720769ac422186de2b3120;p=profile%2Fivi%2Fkernel-x86-ivi.git

Phonet: remove useless locking in device cleanup

Incoming packets and sockets are already gone.
The netdevice notifier is unregistered under the RTNL lock
There remains a race with the rtnetlink handlers unregistration, but it
is a generic RTNL issue that was already present before this change.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
index fd41810..3e24c05 100644
--- a/net/phonet/pn_dev.c
+++ b/net/phonet/pn_dev.c
@@ -204,13 +204,8 @@ void phonet_device_exit(void)
 	struct phonet_device *pnd, *n;
 
 	rtnl_unregister_all(PF_PHONET);
-	rtnl_lock();
-	spin_lock_bh(&pndevs.lock);
+	unregister_netdevice_notifier(&phonet_device_notifier);
 
 	list_for_each_entry_safe(pnd, n, &pndevs.list, list)
 		__phonet_device_free(pnd);
-
-	spin_unlock_bh(&pndevs.lock);
-	rtnl_unlock();
-	unregister_netdevice_notifier(&phonet_device_notifier);
 }