From: Magnus Damm Date: Mon, 10 Aug 2009 21:41:18 +0000 (+0200) Subject: PM / Driver Core: Kill dev_pm_ops platform warning for now X-Git-Tag: v2.6.31-rc6~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=651b1f125c7e3806bbd635739d009433dc07372d;p=profile%2Fivi%2Fkernel-x86-ivi.git PM / Driver Core: Kill dev_pm_ops platform warning for now Commit 783ea7d4eeefe895f2731fe73ac951e94418927b (Driver Core: Rework platform suspend/resume, print warning) added a warning message printed for platform drivers that use the legacy PM callbacks rather than struct dev_pm_ops. Unfortunately, this resulted in some confusion and made some people try to convert drivers by replacing the old callbacks with struct dev_pm_ops in automatic way, which generally is not a good idea. Remove the platform device runtime dev_pm_ops warning for now, because it's annoying to users and it's not really necessary right now. [rjw: Modified the changelog to be more informative.] Signed-off-by: Magnus Damm Acked-by: Greg Kroah-Hartman Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 81cb01b..456594b 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -483,9 +483,6 @@ int platform_driver_register(struct platform_driver *drv) drv->driver.remove = platform_drv_remove; if (drv->shutdown) drv->driver.shutdown = platform_drv_shutdown; - if (drv->suspend || drv->resume) - pr_warning("Platform driver '%s' needs updating - please use " - "dev_pm_ops\n", drv->driver.name); return driver_register(&drv->driver); }