From: Alyssa Rosenzweig <alyssa@collabora.com>
Date: Fri, 6 May 2022 16:57:14 +0000 (-0400)
Subject: pan/va: Add some whitespace to Valhall disassembly
X-Git-Tag: upstream/22.3.5~9353
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6510c8fa7fc87fb7c8b39c8416384f056c8f654a;p=platform%2Fupstream%2Fmesa.git

pan/va: Add some whitespace to Valhall disassembly

Makes it easier to read.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16409>
---

diff --git a/src/panfrost/bifrost/valhall/disassemble.h b/src/panfrost/bifrost/valhall/disassemble.h
index 973888c..38eba1c 100644
--- a/src/panfrost/bifrost/valhall/disassemble.h
+++ b/src/panfrost/bifrost/valhall/disassemble.h
@@ -43,9 +43,10 @@ disassemble_valhall(FILE *fp, const uint64_t *code, unsigned size, bool verbose)
    for (unsigned i = 0; i < (size / 8); ++i) {
       uint64_t instr = code[i];
 
-      /* TODO: is there a stop-bit? or does all-0's mean stop? */
-      if (instr == 0)
+      if (instr == 0) {
+         fprintf(fp, "\n");
          return;
+      }
 
       if (verbose) {
          /* Print byte pattern */
@@ -53,11 +54,16 @@ disassemble_valhall(FILE *fp, const uint64_t *code, unsigned size, bool verbose)
             fprintf(fp, "%02x ", (uint8_t) (instr >> (j * 8)));
 
          fprintf(fp, "   ");
+      } else {
+         /* Print whitespace */
+         fprintf(fp, "   ");
       }
 
       va_disasm_instr(fp, instr);
       fprintf(fp, "\n");
    }
+
+   fprintf(fp, "\n");
 }
 
 #endif