From: Oleg Nesterov <oleg@redhat.com>
Date: Fri, 6 Jun 2014 21:36:44 +0000 (-0700)
Subject: ptrace: task_clear_jobctl_trapping()->wake_up_bit() needs mb()
X-Git-Tag: v4.9.8~6305^2~4^2~102
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=650226bd95817d727c9a388752d72ef292c4a668;p=platform%2Fkernel%2Flinux-rpi3.git

ptrace: task_clear_jobctl_trapping()->wake_up_bit() needs mb()

__wake_up_bit() checks waitqueue_active() and thus the caller needs mb()
as wake_up_bit() documents, fix task_clear_jobctl_trapping().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/kernel/signal.c b/kernel/signal.c
index 6e600aaa..9b5453e 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -277,6 +277,7 @@ void task_clear_jobctl_trapping(struct task_struct *task)
 {
 	if (unlikely(task->jobctl & JOBCTL_TRAPPING)) {
 		task->jobctl &= ~JOBCTL_TRAPPING;
+		smp_mb();	/* advised by wake_up_bit() */
 		wake_up_bit(&task->jobctl, JOBCTL_TRAPPING_BIT);
 	}
 }