From: Michal Bloch Date: Fri, 9 May 2025 16:30:06 +0000 (+0200) Subject: Fix some comments. X-Git-Tag: accepted/tizen/9.0/unified/20250520.172324~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=64d17488e2e356cc2c0fb9ee4145fcd7044dc3f8;p=platform%2Fcore%2Fsystem%2Fsessiond.git Fix some comments. Change-Id: Id1139f2484a6d5aed991e6d2425d4f32cd6d771d --- diff --git a/src/service/src/main_restore.cpp b/src/service/src/main_restore.cpp index fbd8b3f..6d431e2 100644 --- a/src/service/src/main_restore.cpp +++ b/src/service/src/main_restore.cpp @@ -90,7 +90,14 @@ static void restore_user_session(const fs::path& user_home_dir) std::ifstream(get_last_subsession_path_by_user_id(uid), std::ios::in) >> last_subsession; } catch (const std::exception &ex) { LOGE("Could not retrieve last subsession of user %s (uid %d)", username.c_str(), uid); - return; // FIXME the file not existing is actually fine (1st run) but actual errors are probably not + + /* Don't rethrow since the most common errors are fine: + * - name doesn't necessarily map to an existing UID, + * this can happen e.g. when you install debug rpm + * packages which leaves some build artifacts under + * the `abuild` folder which isn't a user on target. + * - at first boot, the last subsession file won't exist. */ + return; } if (!subsession_exists(uid, last_subsession)) { diff --git a/src/service/src/plugin_push.cpp b/src/service/src/plugin_push.cpp index 614c3c0..6256489 100644 --- a/src/service/src/plugin_push.cpp +++ b/src/service/src/plugin_push.cpp @@ -47,10 +47,6 @@ extern "C" * * - the plugin receives OnSubsessionX from its own events. * - * - if you call sessiond_internal_x_subsession from within - * OnSubsessionX, there will be an inversion in how D-Bus - * notifications to other processes are ordered - * * - sessiond assumes single-threading and doing anything in * a separate thread is a race condition. */