From: Hans Verkuil <hans.verkuil@cisco.com>
Date: Fri, 21 Jun 2013 19:16:47 +0000 (-0300)
Subject: upstream: [media] saa7164: fix compiler warning
X-Git-Tag: submit/tizen/20141121.110247~2067
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=64c238a4b30a22ef50dad46bce03015c76b3b46c;p=platform%2Fkernel%2Flinux-3.10.git

upstream: [media] saa7164: fix compiler warning

build/media_build/v4l/saa7164-core.c: In function 'saa7164_initdev':
build/media_build/v4l/saa7164-core.c:1192:6: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
  int err, i;
        ^

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164/saa7164-core.c
index e402e23..896bd8b 100644
--- a/drivers/media/pci/saa7164/saa7164-core.c
+++ b/drivers/media/pci/saa7164/saa7164-core.c
@@ -1196,7 +1196,8 @@ static int saa7164_initdev(struct pci_dev *pci_dev,
 	if (NULL == dev)
 		return -ENOMEM;
 
-	if (v4l2_device_register(&pci_dev->dev, &dev->v4l2_dev)) {
+	err = v4l2_device_register(&pci_dev->dev, &dev->v4l2_dev);
+	if (err < 0) {
 		dev_err(&pci_dev->dev, "v4l2_device_register failed\n");
 		goto fail_free;
 	}