From: Dmitry Osipenko Date: Thu, 30 Jun 2022 20:07:18 +0000 (+0300) Subject: drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling X-Git-Tag: v6.6.17~3937^2~23^2~1937 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=64b88afbd92fbf434759d1896a7cf705e1c00e79;p=platform%2Fkernel%2Flinux-rpi.git drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling Previous commit fixed checking of the ERR_PTR value returned by drm_gem_shmem_get_sg_table(), but it missed to zero out the shmem->pages, which will crash virtio_gpu_cleanup_object(). Add the missing zeroing of the shmem->pages. Fixes: c24968734abf ("drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init") Reviewed-by: Emil Velikov Signed-off-by: Dmitry Osipenko Link: http://patchwork.freedesktop.org/patch/msgid/20220630200726.1884320-2-dmitry.osipenko@collabora.com Signed-off-by: Gerd Hoffmann --- diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c index 1cc8f3f..87b19b3 100644 --- a/drivers/gpu/drm/virtio/virtgpu_object.c +++ b/drivers/gpu/drm/virtio/virtgpu_object.c @@ -170,6 +170,7 @@ static int virtio_gpu_object_shmem_init(struct virtio_gpu_device *vgdev, shmem->pages = drm_gem_shmem_get_sg_table(&bo->base); if (IS_ERR(shmem->pages)) { drm_gem_shmem_unpin(&bo->base); + shmem->pages = NULL; return PTR_ERR(shmem->pages); }