From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 23 Jun 2017 15:17:04 +0000 (+0300)
Subject: net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power()
X-Git-Tag: v4.14-rc1~596^2~93
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=64b2f72671a9a8cbea1aa575d3ea3998987e8c53;p=platform%2Fkernel%2Flinux-rpi3.git

net: dsa: mv88e6xxx: fix error code in mv88e6390_serdes_power()

We're accidentally returning the wrong variable.  "cmode" is
uninitialized at this point so it causes a static checker warning.

Fixes: 6335e9f2446b ("net: dsa: mv88e6xxx: mv88e6390X SERDES support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
index 411b4f5..f3c0111 100644
--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -192,7 +192,7 @@ int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)
 
 	err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
 	if (err)
-		return cmode;
+		return err;
 
 	switch (port) {
 	case 2: