From: Chen Gang Date: Wed, 21 Aug 2013 09:09:33 +0000 (+0800) Subject: can: c_can: fix error checking of priv->instance in probe() X-Git-Tag: upstream/snapshot3+hdmi~4422^2~194^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6439fbce1075dedfe23165c136f19f44c00ca132;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git can: c_can: fix error checking of priv->instance in probe() This patch adds a type cast from 'unsigned int' to 'int'. 'priv->instance' may less than zero, so need a type cast, the related warnings (allmodconfig, "EXTRA_CFLAGS=-W"): drivers/net/can/c_can/c_can_platform.c:198:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Signed-off-by: Chen Gang Signed-off-by: Marc Kleine-Budde --- diff --git a/drivers/net/can/c_can/c_can_platform.c b/drivers/net/can/c_can/c_can_platform.c index c6f838d..294ced3 100644 --- a/drivers/net/can/c_can/c_can_platform.c +++ b/drivers/net/can/c_can/c_can_platform.c @@ -195,7 +195,7 @@ static int c_can_plat_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 1); priv->raminit_ctrlreg = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(priv->raminit_ctrlreg) || priv->instance < 0) + if (IS_ERR(priv->raminit_ctrlreg) || (int)priv->instance < 0) dev_info(&pdev->dev, "control memory is not used for raminit\n"); else priv->raminit = c_can_hw_raminit;