From: Rafael Espindola Date: Tue, 27 Feb 2018 23:44:36 +0000 (+0000) Subject: Pass a GlobalDecl to setFunctionDefinitionAttributes. NFC. X-Git-Tag: llvmorg-7.0.0-rc1~11824 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=64393cfca022da671ea086b6fc497084cd062306;p=platform%2Fupstream%2Fllvm.git Pass a GlobalDecl to setFunctionDefinitionAttributes. NFC. This just makes a followup patch easier to read. llvm-svn: 326265 --- diff --git a/clang/lib/CodeGen/CGCXX.cpp b/clang/lib/CodeGen/CGCXX.cpp index 5ef4dc4..d50e4bc 100644 --- a/clang/lib/CodeGen/CGCXX.cpp +++ b/clang/lib/CodeGen/CGCXX.cpp @@ -230,7 +230,7 @@ llvm::Function *CodeGenModule::codegenCXXStructor(const CXXMethodDecl *MD, setFunctionDLLStorageClass(GD, Fn); CodeGenFunction(*this).GenerateCode(GD, Fn, FnInfo); - setFunctionDefinitionAttributes(MD, Fn); + setFunctionDefinitionAttributes(GD, Fn); SetLLVMFunctionAttributesForDefinition(MD, Fn); return Fn; } diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 588d001..36a0b9e 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -1080,9 +1080,9 @@ llvm::ConstantInt *CodeGenModule::CreateCrossDsoCfiTypeId(llvm::Metadata *MD) { return llvm::ConstantInt::get(Int64Ty, llvm::MD5Hash(MDS->getString())); } -void CodeGenModule::setFunctionDefinitionAttributes(const FunctionDecl *D, +void CodeGenModule::setFunctionDefinitionAttributes(GlobalDecl GD, llvm::Function *F) { - setNonAliasAttributes(D, F); + setNonAliasAttributes(GD.getDecl(), F); } void CodeGenModule::SetLLVMFunctionAttributes(const Decl *D, @@ -3591,7 +3591,7 @@ void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD, CodeGenFunction(*this).GenerateCode(D, Fn, FI); - setFunctionDefinitionAttributes(D, Fn); + setFunctionDefinitionAttributes(GD, Fn); SetLLVMFunctionAttributesForDefinition(D, Fn); if (const ConstructorAttr *CA = D->getAttr()) diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index c8b2d78..40a9d93 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -1183,8 +1183,7 @@ public: bool TryEmitBaseDestructorAsAlias(const CXXDestructorDecl *D); /// Set attributes for a global definition. - void setFunctionDefinitionAttributes(const FunctionDecl *D, - llvm::Function *F); + void setFunctionDefinitionAttributes(GlobalDecl GD, llvm::Function *F); llvm::GlobalValue *GetGlobalValue(StringRef Ref);