From: Brett Creeley Date: Mon, 21 Aug 2023 18:42:15 +0000 (-0700) Subject: vfio/pds: Send type for SUSPEND_STATUS command X-Git-Tag: v6.6.7~2038^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=642265e22ecc7fe05c49cb8e1e0000a049df9857;p=platform%2Fkernel%2Flinux-starfive.git vfio/pds: Send type for SUSPEND_STATUS command Commit bb500dbe2ac6 ("vfio/pds: Add VFIO live migration support") added live migration support for the pds-vfio-pci driver. When sending the SUSPEND command to the device, the driver sets the type of suspend (i.e. P2P or FULL). However, the driver isn't sending the type of suspend for the SUSPEND_STATUS command, which will result in failures. Fix this by also sending the suspend type in the SUSPEND_STATUS command. Fixes: bb500dbe2ac6 ("vfio/pds: Add VFIO live migration support") Signed-off-by: Brett Creeley Signed-off-by: Shannon Nelson Reviewed-by: Simon Horman Link: https://lore.kernel.org/r/20230821184215.34564-1-brett.creeley@amd.com Signed-off-by: Alex Williamson --- diff --git a/drivers/vfio/pci/pds/cmds.c b/drivers/vfio/pci/pds/cmds.c index b0d8844..36463cc 100644 --- a/drivers/vfio/pci/pds/cmds.c +++ b/drivers/vfio/pci/pds/cmds.c @@ -86,12 +86,13 @@ void pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio) } static int -pds_vfio_suspend_wait_device_cmd(struct pds_vfio_pci_device *pds_vfio) +pds_vfio_suspend_wait_device_cmd(struct pds_vfio_pci_device *pds_vfio, u8 type) { union pds_core_adminq_cmd cmd = { .lm_suspend_status = { .opcode = PDS_LM_CMD_SUSPEND_STATUS, .vf_id = cpu_to_le16(pds_vfio->vf_id), + .type = type, }, }; struct device *dev = pds_vfio_to_dev(pds_vfio); @@ -156,7 +157,7 @@ int pds_vfio_suspend_device_cmd(struct pds_vfio_pci_device *pds_vfio, u8 type) * The subsequent suspend status request(s) check if the firmware has * completed the device suspend process. */ - return pds_vfio_suspend_wait_device_cmd(pds_vfio); + return pds_vfio_suspend_wait_device_cmd(pds_vfio, type); } int pds_vfio_resume_device_cmd(struct pds_vfio_pci_device *pds_vfio, u8 type)