From: Yanmin Zhang Date: Tue, 10 Jan 2012 23:48:21 +0000 (-0800) Subject: intel_idle: remove redundant local_irq_disable() call X-Git-Tag: v3.3-rc1~8^2^3~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=63ff07beaebef2a82da41cf04053ae88b579226d;p=platform%2Fkernel%2Flinux-exynos.git intel_idle: remove redundant local_irq_disable() call irq disabling happens earlier in process_32.c:cpu_idle. Basically, cpuidle_state->enter is called, cpu irq is disabled. cpuidle_state->enter would turn on irq when exiting. intel_idle doesn't follow this assumption. Although it doesn't cause real issue, it misleads developers. Remove the call to local_irq_disable() at entry. [akpm@linux-foundation.org: add comment] Signed-off-by: Mingming Zhang Signed-off-by: Andrew Morton Signed-off-by: Len Brown --- diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index af0b4a5..920c61c 100644 --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -232,6 +232,7 @@ static int get_driver_data(int cstate) * @drv: cpuidle driver * @index: index of cpuidle state * + * Must be called under local_irq_disable(). */ static int intel_idle(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) @@ -247,8 +248,6 @@ static int intel_idle(struct cpuidle_device *dev, cstate = (((eax) >> MWAIT_SUBSTATE_SIZE) & MWAIT_CSTATE_MASK) + 1; - local_irq_disable(); - /* * leave_mm() to avoid costly and often unnecessary wakeups * for flushing the user TLB's associated with the active mm.