From: Stefan Theil Date: Thu, 8 Mar 2018 08:00:13 +0000 (+0100) Subject: tools/mkimage: Use proper output parameter in dtc-system call X-Git-Tag: v2018.03~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=63f881d46a9745139235be9d8cb892ada6159ea1;p=platform%2Fkernel%2Fu-boot.git tools/mkimage: Use proper output parameter in dtc-system call The system call used by mkimage to run dtc redirects stdout to a temporary file. This can cause problems on Windows (with a MinGW cross-compiled version). Using the "-o" dtc parameter avoids this problem. Signed-off-by: Stefan Theil Reviewed-by: Tom Rini --- diff --git a/tools/fit_image.c b/tools/fit_image.c index 1db44f47a1..3f5cc20e49 100644 --- a/tools/fit_image.c +++ b/tools/fit_image.c @@ -650,9 +650,9 @@ static int fit_handle_file(struct image_tool_params *params) } *cmd = '\0'; } else if (params->datafile) { - /* dtc -I dts -O dtb -p 500 datafile > tmpfile */ - snprintf(cmd, sizeof(cmd), "%s %s \"%s\" > \"%s\"", - MKIMAGE_DTC, params->dtc, params->datafile, tmpfile); + /* dtc -I dts -O dtb -p 500 -o tmpfile datafile */ + snprintf(cmd, sizeof(cmd), "%s %s -o \"%s\" \"%s\"", + MKIMAGE_DTC, params->dtc, tmpfile, params->datafile); debug("Trying to execute \"%s\"\n", cmd); } else { snprintf(cmd, sizeof(cmd), "cp \"%s\" \"%s\"",