From: Ian Romanick <ian.d.romanick@intel.com>
Date: Mon, 5 Apr 2010 21:35:47 +0000 (-0700)
Subject: Set lower bound on size implied by whole-array assignment
X-Git-Tag: 062012170305~10660^2~625^2~431
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=63f394203a8be9b87f8617cd7a56a0806c0870b3;p=profile%2Fivi%2Fmesa.git

Set lower bound on size implied by whole-array assignment

When an unsized array is accessed with a constant extension index this
sets a lower bound on the allowable sizes.  When the unsized array
gets a size set due to a whole-array assignment, this size must be at
least as large as the implied lower bound.

This causes the following tests to pass:

    glslparsertest/glsl2/array-16.vert
---

diff --git a/ast_to_hir.cpp b/ast_to_hir.cpp
index c9f93cb..9d067be 100644
--- a/ast_to_hir.cpp
+++ b/ast_to_hir.cpp
@@ -489,6 +489,13 @@ do_assignment(exec_list *instructions, struct _mesa_glsl_parse_state *state,
 
 	 assert(var != NULL);
 
+	 if (var->max_array_access >= unsigned(rhs->type->array_size())) {
+	    /* FINISHME: This should actually log the location of the RHS. */
+	    _mesa_glsl_error(& lhs_loc, state, "array size must be > %u due to "
+			     "previous access",
+			     var->max_array_access);
+	 }
+
 	 var->type = glsl_type::get_array_instance(lhs->type->element_type(),
 						   rhs->type->array_size());
       }