From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Mon, 16 Apr 2018 11:17:53 +0000 (+0200)
Subject: gpio: fix error path in lineevent_create
X-Git-Tag: v4.9.100~18
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=63e2ae9d75d4c348f47600dcef0f3d90eef7f34e;p=platform%2Fkernel%2Flinux-amlogic.git

gpio: fix error path in lineevent_create

commit f001cc351ad3309ec8736c374e90e5a4bc472d41 upstream.

If gpiod_request() fails the cleanup must not call gpiod_free().

Cc: stable@vger.kernel.org
Fixes: 61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 68102e262922..56b24198741c 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -795,7 +795,7 @@ static int lineevent_create(struct gpio_device *gdev, void __user *ip)
 	desc = &gdev->descs[offset];
 	ret = gpiod_request(desc, le->label);
 	if (ret)
-		goto out_free_desc;
+		goto out_free_label;
 	le->desc = desc;
 	le->eflags = eflags;