From: Youngsoo Choi Date: Mon, 2 Apr 2018 08:52:13 +0000 (-0700) Subject: [M63] Switch deprecated ForceSet with DefineOwnProperty X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=632ec05ede81ac727b9ed36de480b9149709e331;p=platform%2Fframework%2Fweb%2Fcrosswalk-tizen.git [M63] Switch deprecated ForceSet with DefineOwnProperty ForceSet has been deprecated in v8 version 6.3.292. So, this switches the ForceSet with DefineOwnProperty. Change-Id: Ied9dcf71ec447b9a1dcd15c4b6ab6ed8420a20d6 Signed-off-by: Youngsoo Choi --- diff --git a/extensions/renderer/xwalk_module_system.cc b/extensions/renderer/xwalk_module_system.cc index 22181886d..e2d1a9af5 100755 --- a/extensions/renderer/xwalk_module_system.cc +++ b/extensions/renderer/xwalk_module_system.cc @@ -516,7 +516,7 @@ void XWalkModuleSystem::EnsureExtensionNamespaceIsReadOnly( v8::Handle v8_extension_name( v8::String::NewFromUtf8(context->GetIsolate(), basename.c_str())); - value.As()->ForceSet( + value.As()->DefineOwnProperty(context, v8_extension_name, value.As()->Get(v8_extension_name), v8::ReadOnly); } diff --git a/extensions/renderer/xwalk_v8tools_module.cc b/extensions/renderer/xwalk_v8tools_module.cc index 4fcad3716..941851d3d 100755 --- a/extensions/renderer/xwalk_v8tools_module.cc +++ b/extensions/renderer/xwalk_v8tools_module.cc @@ -18,7 +18,11 @@ void ForceSetPropertyCallback( if (info.Length() != 3 || !info[0]->IsObject() || !info[1]->IsString()) { return; } - info[0].As()->ForceSet(info[1], info[2]); + v8::Isolate* isolate = v8::Isolate::GetCurrent(); + v8::Local ctx = isolate->GetCurrentContext(); + v8::String::Utf8Value value(info[1]); + v8::Local key = v8::String::NewFromUtf8(isolate, *value); + info[0].As()->DefineOwnProperty(ctx, key, info[2]); } // ================