From: Dave Stevenson Date: Mon, 18 Dec 2023 11:49:36 +0000 (+0000) Subject: input: edt-ft5x06: Correct prefix length in snprintf X-Git-Tag: accepted/tizen/unified/20240422.153132~181 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6324c93d1f2734625711049ef6e975d3edf4d37b;p=platform%2Fkernel%2Flinux-rpi.git input: edt-ft5x06: Correct prefix length in snprintf snprintf takes the length of the array that we can print into, and has to fit the NULL terminator in there too. Printing the prefix is generally "12-3456 " which is 8 desired characters (the length of EDT_NAME_PREFIX_LEN) and the NULL. The space is therefore being truncated to fit the NULL in. Increase the length snprintf is allowed to use. Signed-off-by: Dave Stevenson --- diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 1b82821..1d2b8df 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -938,7 +938,7 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client, char *model_name = tsdata->name; char *fw_version = tsdata->fw_version; - snprintf(model_name, EDT_NAME_PREFIX_LEN, "%s ", dev_name(&client->dev)); + snprintf(model_name, EDT_NAME_PREFIX_LEN + 1, "%s ", dev_name(&client->dev)); model_name += strlen(model_name); /* see what we find if we assume it is a M06 *