From: Ludovic Desroches Date: Tue, 15 Sep 2015 13:38:24 +0000 (+0200) Subject: dmaengine: at_xdmac: fix memory leak in interleaved mode X-Git-Tag: v4.14-rc1~4358^2~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=62b5cb757f1d6c875293958535952dd38ff9e675;p=platform%2Fkernel%2Flinux-rpi.git dmaengine: at_xdmac: fix memory leak in interleaved mode In interleaved mode, when numf > 1, we have only one descriptor for the transfer but this descriptor has to be added to the descs_list. If not, when doing remove_xfer, the descriptor won't be put back in the free_descs_list. Signed-off-by: Ludovic Desroches Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 0190d1c..2ab6fe7 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -958,6 +958,10 @@ at_xdmac_prep_interleaved(struct dma_chan *chan, xt, xt->sgl); for (i = 0; i < xt->numf; i++) at_xdmac_increment_block_count(chan, first); + + dev_dbg(chan2dev(chan), "%s: add desc 0x%p to descs_list 0x%p\n", + __func__, first, first); + list_add_tail(&first->desc_node, &first->descs_list); } else { for (i = 0; i < xt->frame_size; i++) { size_t src_icg = 0, dst_icg = 0;