From: Jonathan Rosser <jonathan.rosser@rd.bbc.co.uk>
Date: Sun, 5 Sep 2010 22:34:13 +0000 (-0700)
Subject: cog: Fix cog_virt_frame_new_convert_u8()
X-Git-Tag: RELEASE-0.10.21~825
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=62ae33d3d6e4cbfdaaf1a746a6626ff85bde7c99;p=platform%2Fupstream%2Fgst-plugins-bad.git

cog: Fix cog_virt_frame_new_convert_u8()

Conversion was using uninitialized data instead of source frame.
Fixes #626425.
---

diff --git a/ext/cog/cogvirtframe.c b/ext/cog/cogvirtframe.c
index 74336ca8c..860dc8eac 100644
--- a/ext/cog/cogvirtframe.c
+++ b/ext/cog/cogvirtframe.c
@@ -1819,8 +1819,7 @@ convert_u8_s16 (CogFrame * frame, void *_dest, int component, int i)
   int16_t *src;
 
   src = cog_virt_frame_get_line (frame->virt_frame1, component, i);
-  orc_addc_convert_u8_s16 (dest, frame->virt_priv,
-      frame->components[component].width);
+  orc_addc_convert_u8_s16 (dest, src, frame->components[component].width);
 }
 
 CogFrame *
@@ -1834,7 +1833,6 @@ cog_virt_frame_new_convert_u8 (CogFrame * vf)
   virt_frame = cog_frame_new_virtual (NULL, format, vf->width, vf->height);
   virt_frame->virt_frame1 = vf;
   virt_frame->render_line = convert_u8_s16;
-  virt_frame->virt_priv = g_malloc (sizeof (int16_t) * vf->width);
 
   return virt_frame;
 }