From: Lukasz Stanislawski Date: Fri, 29 May 2020 12:17:21 +0000 (+0200) Subject: Add ability to remove genlist separator line X-Git-Tag: submit/tizen/20200603.060747~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6291ed523acb31c32b319ccb77586c639977da8f;p=profile%2Fcommon%2Fapps%2Fnative%2Fsettings.git Add ability to remove genlist separator line Define flag for removing genlist bottom line separator when item becomes realized. Remove bottom lines from Sound & Display menus. Change-Id: I1b44d388386eceb3269d0c3c8fdaa066b0146e71 --- diff --git a/setting-common/include/setting-common-data-type.h b/setting-common/include/setting-common-data-type.h index 1bafaf9..183839e 100755 --- a/setting-common/include/setting-common-data-type.h +++ b/setting-common/include/setting-common-data-type.h @@ -304,6 +304,10 @@ typedef struct _Setting_GenGroupItem_Data { Evas_Object *nf; + /* Emits "elm,state,bottomline,hide" signal to edje when + * item becomes realized */ + bool hide_bottom_line : 1; + } Setting_GenGroupItem_Data; typedef struct { diff --git a/setting-common/src/setting-common-init.c b/setting-common/src/setting-common-init.c index 2d56b54..3c26165 100644 --- a/setting-common/src/setting-common-init.c +++ b/setting-common/src/setting-common-init.c @@ -92,6 +92,8 @@ static void __all_gl_realized_cb(void *data, Evas_Object *obj, void *event_info) } setting_genlist_item_1line_style_auto_apply_substyle(item); + if (item_data->hide_bottom_line) + elm_object_item_signal_emit(item, "elm,state,bottomline,hide", "elm"); } static Evas_Object *_view_list_prepare(MainData *md) diff --git a/setting-display/src/setting-display-brightness.c b/setting-display/src/setting-display-brightness.c index 5e091e6..312aa06 100755 --- a/setting-display/src/setting-display-brightness.c +++ b/setting-display/src/setting-display-brightness.c @@ -680,6 +680,7 @@ void construct_brightness(void *data, Evas_Object *genlist) SETTING_TRACE_ERROR("ad->data_br_header is NULL"); return; } + ad->data_br_header->hide_bottom_line = TRUE; ad->itc_full.func.content_get = __setting_brightness_add_slider; ad->last_requested_level = -1; diff --git a/setting-profile/src/setting-profile-sound-main.c b/setting-profile/src/setting-profile-sound-main.c index 9c6c72c..b304ee1 100755 --- a/setting-profile/src/setting-profile-sound-main.c +++ b/setting-profile/src/setting-profile-sound-main.c @@ -466,6 +466,7 @@ static void _get_lite_main_list(void *data) ret_if(!data); SettingSoundData *ad = (SettingSoundData *)data; + Setting_GenGroupItem_Data *group_item_data; char *app_id = NULL; const char *left_icon = NULL; int mm_value = 0; @@ -561,7 +562,7 @@ static void _get_lite_main_list(void *data) NULL); /* Media group*/ - setting_create_Gendial_field_def( + group_item_data = setting_create_Gendial_field_def( ad->md.genlist, &(ad->itc_1line), NULL, @@ -573,6 +574,8 @@ static void _get_lite_main_list(void *data) _("IDS_ST_BODY_MEDIA"), NULL, NULL); + group_item_data->hide_bottom_line = TRUE; + /* 5.media volume */ if (sound_manager_get_volume(SOUND_TYPE_MEDIA, &mm_value) != SOUND_MANAGER_ERROR_NONE) @@ -610,7 +613,7 @@ static void _get_lite_main_list(void *data) NULL); /* Notifications group */ - setting_create_Gendial_field_def( + group_item_data = setting_create_Gendial_field_def( ad->md.genlist, &(ad->itc_1line), NULL, @@ -622,6 +625,7 @@ static void _get_lite_main_list(void *data) _("IDS_ST_BODY_NOTIFICATIONS"), NULL, NULL); + group_item_data->hide_bottom_line = TRUE; /* 4.noti volumn */ if (sound_manager_get_volume(SOUND_TYPE_NOTIFICATION, &mm_value) @@ -654,7 +658,7 @@ static void _get_lite_main_list(void *data) NULL); /* System group*/ - setting_create_Gendial_field_def( + group_item_data = setting_create_Gendial_field_def( ad->md.genlist, &(ad->itc_1line), NULL, @@ -666,6 +670,8 @@ static void _get_lite_main_list(void *data) _("IDS_ST_BODY_SYSTEM"), NULL, NULL); + group_item_data->hide_bottom_line = TRUE; + left_icon = setting_sound_get_slider_icon(SND_SLIDER_SYSTEM, mm_value); ADD_SOUND_SLIDER( ad->data_touch_volume, genlist, ad->itc_full,