From: Colin Ian King <colin.king@canonical.com>
Date: Tue, 27 Mar 2018 14:30:01 +0000 (+0100)
Subject: ALSA: usb-audio: fix memory leak on cval
X-Git-Tag: v5.15~8973^2~12^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=623760257b39632ffc5051fc88167b546dcfa791;p=platform%2Fkernel%2Flinux-starfive.git

ALSA: usb-audio: fix memory leak on cval

With the current exit return path of the ctl_info allocation failure
cval is not being freed resulting in a memory leak. Fix this by kfree'ing
it on the return.

Detected by CoverityScan, CID#1466878 ("Resource Leak")

Fixes: 21e9b3e931f7 ("ALSA: usb-audio: fix uac control query argument")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 04dab6f..301ad61 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -1365,8 +1365,10 @@ static void build_feature_ctl(struct mixer_build *state, void *raw_desc,
 	cval->cmask = ctl_mask;
 
 	ctl_info = get_feature_control_info(control);
-	if (!ctl_info)
+	if (!ctl_info) {
+		kfree(cval);
 		return;
+	}
 	if (state->mixer->protocol == UAC_VERSION_1)
 		cval->val_type = ctl_info->type;
 	else /* UAC_VERSION_2 */