From: Joe Loser Date: Tue, 19 Oct 2021 18:21:25 +0000 (-0400) Subject: [libc++] Make __weekday_from_days private in weekday X-Git-Tag: upstream/15.0.7~28212 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=622c40722e140239d14a19d1c3b7013de2863fe1;p=platform%2Fupstream%2Fllvm.git [libc++] Make __weekday_from_days private in weekday `weekday` has a static member function `__weekday_from_days` which is not part of the mandated public interface of `weeekday` according to the standard. Since it is only used internally in the constructors of `weekday`, let's make it private. Reviewed By: ldionne, Mordante, #libc Differential Revision: https://reviews.llvm.org/D112072 --- diff --git a/libcxx/include/chrono b/libcxx/include/chrono index 48a8665..5ba405e 100644 --- a/libcxx/include/chrono +++ b/libcxx/include/chrono @@ -1839,6 +1839,7 @@ class weekday_last; class weekday { private: unsigned char __wd; + static constexpr unsigned char __weekday_from_days(int __days) noexcept; public: weekday() = default; inline explicit constexpr weekday(unsigned __val) noexcept : __wd(static_cast(__val == 7 ? 0 : __val)) {} @@ -1858,9 +1859,6 @@ public: inline constexpr bool ok() const noexcept { return __wd <= 6; } constexpr weekday_indexed operator[](unsigned __index) const noexcept; constexpr weekday_last operator[](last_spec) const noexcept; - - // TODO: Make private? - static constexpr unsigned char __weekday_from_days(int __days) noexcept; };