From: Vladimir Zapolskiy <vz@mleia.com>
Date: Tue, 22 Mar 2016 23:06:04 +0000 (+0200)
Subject: net: mediatek: fix checking for NULL instead of IS_ERR() in .probe
X-Git-Tag: v4.9.8~2423^2~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=621e49f6d80a731dd3073569571c4579352cfb1c;p=platform%2Fkernel%2Flinux-rpi3.git

net: mediatek: fix checking for NULL instead of IS_ERR() in .probe

devm_ioremap_resource() returns ERR_PTR() value on error, it never
returns NULL, fix it and propagate the returned error upwards.

Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet")
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
Acked-by: John Crispin <blogic@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 7f2126b..e0b68af 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1690,8 +1690,8 @@ static int mtk_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	eth->base = devm_ioremap_resource(&pdev->dev, res);
-	if (!eth->base)
-		return -EADDRNOTAVAIL;
+	if (IS_ERR(eth->base))
+		return PTR_ERR(eth->base);
 
 	spin_lock_init(&eth->page_lock);